[haiku-development] Should we address warnings?
- From: scott mc <scottmc2@xxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Wed, 8 Jul 2009 08:31:38 -0700
What's the general rule on fixing compile warnings? When building the
entire Haiku trunk I usually see hundereds of warnings, which of these
are ok to ignore and which ones should be addressed? Here's an
example:
src/build/libbe/interface/Bitmap.cpp:1156: note:
‘color.rgb_color_value::alpha’ was declared here
src/build/libbe/interface/Bitmap.cpp:939: warning:
‘color.rgb_color_value::alpha’ may be used uninitialized in this
function
src/build/libbe/interface/Bitmap.cpp:1165: note:
‘color.rgb_color_value::alpha’ was declared here
src/build/libbe/interface/Bitmap.cpp:939: warning:
‘color.rgb_color_value::alpha’ may be used uninitialized in this
function
src/build/libbe/interface/Bitmap.cpp:1156: note:
I would think it'd be ok to fix warnings in Haiku specific code, but
not worry too much about warnings we see in code that's been used from
BSD and elsewhere? I'm using gcc2 in case that matters, here's
another in ported code:
Cc generated/objects/haiku/x86/release/bin/tar/lib/umaxtostr.o
Cc generated/objects/haiku/x86/release/bin/tar/lib/unlinkdir.o
Cc generated/objects/haiku/x86/release/bin/tar/lib/utime.o
src/bin/tar/lib/utime.c:104: warning: no previous prototype for `rpl_utime'
Cc generated/objects/haiku/x86/release/bin/tar/lib/utimens.o
Cc generated/objects/haiku/x86/release/bin/tar/lib/version-etc.o
Cc generated/objects/haiku/x86/release/bin/tar/lib/version-etc-fsf.o
Cc generated/objects/haiku/x86/release/bin/tar/lib/waitpid.o
src/bin/tar/lib/waitpid.c:37: warning: no previous prototype for `waitpid'
src/bin/tar/lib/waitpid.c: In function `waitpid':
src/bin/tar/lib/waitpid.c:58: warning: implicit declaration of function `wait'
Cc generated/objects/haiku/x86/release/bin/tar/lib/xalloc-die.o
Cc generated/objects/haiku/x86/release/bin/tar/lib/xgetcwd.o
Just wondering.
-scottmc
Other related posts:
