Howdy *,
Okay, so my time window to rework my patch has elapsed and I have some
important changes to disclose:
BColorMap has been removed.
This was no small task, but at least there's not an extra class laying
around now.
To accomplish this all of the following, and more, was performed:
BMessage acquired *Color() methods
InterfaceDefs has new methods:
const char* ui_color_name(color_which)
color_which which_ui_color(const char* name)
void set_ui_color(const BMessage* colors)
Appearance app handles colors using the new API
Desktop thread now holds the write lock during the color update for all
windows, this is less than ideal, but it actually works quite well.
This does remove one point of use for DelayedMessage, however
DelayedMessage remains.
In addition, there are some style cleanups and a minor bug fix or two
included and I rebased from the current Haiku repository.
And, finally, I completely rewrote the commit history again, and created
a much faster and simpler means by which to accomplish this, so there is
absolutely no noise in the commit history in the 4a patch. The history
is sorted almost exactly as it was after the last time I rewrote it,
though no BColorMap mentions (obviously) and I merged a couple smaller
commits into the primary commit as they were not able to stand on their own.
The end commit size has not changed much, even with the removal of
BColorMap, and you can find the patches here:
http://files.looncraz.net/svc/
Thanks!
--The loon
