[haiku-development] Re: Savage Video Driver

Axel Dörfler wrote:

Gerald Zajac <zajacg@xxxxxxxxxxxxx> wrote:
I would like to thank korli for entering the Savage driver source files into the repository. However, I noticed that Erdi Chen's license files (files named LICENSE) are still in the repository with the driver and accelerant source files. Since this driver is a complete rewrite of his driver except for a small amount of his cursor code and Erdi Chen is given credit for the cursor code in the copyright notices of the source file *savage_cursor.c*, I do not feel that the LICENSE text files are needed. 

I've removed them now, and also added the driver to the image.
Thanks for adding the driver to the image; however, the driver currently doesn't work because the name of the accelerant is different than the name I was using before I submitted the source code to the project. I would send a diff file for this fix; but at the current time, I do not have a computer set up where I can check out the source files from the repository. Nevertheless, it is a single line change at line 758 in file: */haiku/trunk/src/add-ons/kernel/drivers/graphics/s3savage/driver.c*
At line 758 which is in function control_hook(), there is a call to strcpy() which sets the name of the accelerant file. If you change it from *"savage.accelerant"* to *"s3savage.accelerant"* the driver/accelerant will work.
There is one other minor problem in that the TRACE statements for debug output to the syslog are not enabled. I do not know if there is a standard way for doing this in the Haiku project; but I had defined *DEBUG* in the makefiles that were previously used for building the driver. If something similar can not be done in the jam files, I suggest inserting a *#define DEBUG* statement before line 24 where DEBUG is tested in file driver.c. To also enable debug output in the accelerant, also insert a *#define DEBUG* statement before line 26 where DEBUG is tested in file: */haiku/trunk/src/add-ons/accelerants/s3savage/GlobalData.h*.
I hope I have not created too much inconvenience by not submitting a diff file. 

Best regards,
Gerald

Other related posts: