Gerald Zajac <zajacg@xxxxxxxxxxxxx> wrote:
There are two possible fixes for this problem. One is to disable
accelerated drawing for 1400x1050 on the chips that have this
problem,
and the other fix is change the width to 1392 or 1408 (which are
divisible by 32) when setting the mode. I prefer the second option
where a width of 1392 used. The list of modes would be unchanged and
would list 1400x1050 as one of the modes; however, when the mode is
set, h_display in struct display_timing will be changed to 1392.
1392
will be used instead of 1408 because on a laptop display such as the
Thinkpad T23 1408 causes the rightmost 8 pixels to be off the right
edge
of the display; whereas, 1392 causes only a very narrow blank strip
on
the left edge of the screen. With an external monitor, the user is
not
aware that the display width is not exactly 1400. Note that the
width
will be changed only for the chips that have this problem.
If there are no serious objections, I will implement the my preferred
fix as described above.
The usual way for cases like this is to make the bitmap larger, not
smaller - the user won't notice the extra space anywhere (ie. it won't
be shown, only the internal frame buffer is larger).
IOW you would not change what the display_mode returns, but only change
frame_buffer_config::bytes_per_row.
