[haiku-development] Re: Review & Pull request for Workspaces app
- From: devine-mlist@xxxxxxxxxxx
- To: <haiku-development@xxxxxxxxxxxxx>
- Date: Tue, 13 Dec 2011 12:59:26 +1000
On Tue, 13 Dec 2011 00:56:39 +0100, Ingo Weinhold wrote:
I'd say creating a ticket with the reference to your branch is a good
idea nonetheless.
The trouble at the moment is that a branch may solve both bugs and
enhancements so I was not sure which to file that under. Perhaps there
should be a category for pull requests? It makes sense because then
conversation on what needs to be done to get the request accepted can be
tracked in Trac.
I suspect you'd like the whole branch [1] to be merged, right? Or is
the reference to ec90b9219bb6 (the penultimate commit) intentional?
Given that the latest commit (making getters non-const) seems
counterproductive, I'd agree, though.
I was intending for the whole branch to be merged. I actually also
intended to put the latest reference that I had done before I sent the
email but I screwed that up and it was one behind.
Counter-productive? I had better go read up on const then.
* Please clean up your commit messages to conform to the recommended
format (cf. [2]).
Certainly.
* Please clean up the commits.
I need to work out how to make Git do what I need... Can somebody link
to documentation on the appropriate workflow for achieving this?
--Daniel Devine
Other related posts:
