[haiku-development] Re: Review & Pull request for Workspaces app

  • From: devine-mlist@xxxxxxxxxxx
  • To: <haiku-development@xxxxxxxxxxxxx>
  • Date: Fri, 16 Dec 2011 02:09:57 +1000

The changes were easy.

On Thu, 15 Dec 2011 14:25:44 +0100, Stephan Aßmus wrote:
lines 362 and 363:
if (status == B_OK)
        status = archive->AddString("class", "WorkspacesView");

Yeah I think you're right. I took the code out and I can't find any difference.

I think you're right about the possible combining of several things into one smarter piece of code. I may do that later, or give it to somebody else looking for an entry-level job.

Thanks for taking the time to look through the code!

--Daniel Devine

Other related posts: