[haiku-development] Re: [PATCH] Bootloader safe mode help text

Here is the revised patch for the bootloader help text, with the reference
to "Haiku" removed and the phrase "the system" used instead.
Thanks for spotting that scottmc. :-)

David Powell.




Index: src/system/boot/platform/bios_ia32/smp.cpp
===================================================================
--- src/system/boot/platform/bios_ia32/smp.cpp    (revision 26178)
+++ src/system/boot/platform/bios_ia32/smp.cpp    (working copy)
@@ -589,6 +589,7 @@
     menu->AddItem(item);
     item->SetData(B_SAFEMODE_DISABLE_SMP);
     item->SetType(MENU_ITEM_MARKABLE);
+    item->SetHelpText("Disables all but one CPU core.");
 }


Index: src/system/boot/platform/bios_ia32/menu.cpp
===================================================================
--- src/system/boot/platform/bios_ia32/menu.cpp    (revision 26178)
+++ src/system/boot/platform/bios_ia32/menu.cpp    (working copy)
@@ -26,22 +26,25 @@
             menu->AddItem(item = new(nothrow) MenuItem("Use fail-safe video
mode"));
             item->SetType(MENU_ITEM_MARKABLE);
             item->SetData(B_SAFEMODE_FAIL_SAFE_VIDEO_MODE);
-            item->SetHelpText("The system will use VESA mode and won't try
to open any video graphics driver");
+            item->SetHelpText("The system will use VESA mode and won't try
to use any video graphics drivers.");

             smp_add_safemode_menus(menu);

             menu->AddItem(item = new(nothrow) MenuItem("Don't call the
BIOS"));
             item->SetType(MENU_ITEM_MARKABLE);
+            item->SetHelpText("Stops the system from calling BIOS
functions.");

             menu->AddItem(item = new(nothrow) MenuItem("Disable APM"));
             item->SetType(MENU_ITEM_MARKABLE);
             item->SetData(B_SAFEMODE_DISABLE_APM);
-            item->SetHelpText("This overrides the APM setting in the kernel
settings file");
+            item->SetHelpText("Disables Advanced Power Management hardware
support, "
+                "overriding the APM setting in the kernel settings file.");

             menu->AddItem(item = new(nothrow) MenuItem("Disable ACPI"));
             item->SetType(MENU_ITEM_MARKABLE);
             item->SetData(B_SAFEMODE_DISABLE_ACPI);
-            item->SetHelpText("This overrides the ACPI setting in the
kernel settings file");
+            item->SetHelpText("Disables Advanced Configuration and Power
Interface hardware support, "
+                "overriding the ACPI setting in the kernel settings
file.");
             break;
         default:
             break;
Index: src/system/boot/loader/menu.cpp
===================================================================
--- src/system/boot/loader/menu.cpp    (revision 26178)
+++ src/system/boot/loader/menu.cpp    (working copy)
@@ -444,18 +444,21 @@
     safeMenu->AddItem(item = new(nothrow) MenuItem("Disable user
add-ons"));
     item->SetData(B_SAFEMODE_DISABLE_USER_ADD_ONS);
     item->SetType(MENU_ITEM_MARKABLE);
-    item->SetHelpText("Prevent all user installed add-ons to be loaded.
Only the add-ons "
+    item->SetHelpText("Prevents all user installed add-ons from being
loaded. Only the add-ons "
         "in the system directory will be used.");

     safeMenu->AddItem(item = new(nothrow) MenuItem("Disable IDE DMA"));
     item->SetData(B_SAFEMODE_DISABLE_IDE_DMA);
     item->SetType(MENU_ITEM_MARKABLE);
+    item->SetHelpText("Disables IDE DMA, increasing IDE compatibilty at the
expense of performance.");

     platform_add_menus(safeMenu);

     safeMenu->AddItem(item = new(nothrow) MenuItem("Enable on screen debug
output"));
     item->SetData("debug_screen");
     item->SetType(MENU_ITEM_MARKABLE);
+    item->SetHelpText("Displays debug output on screen while the system is
booting, "
+        "instead of the normal boot logo.");

     safeMenu->AddSeparatorItem();
     safeMenu->AddItem(item = new(nothrow) MenuItem("Return to main menu"));

Other related posts: