[haiku-development] Re: Launchbox 80 char limit fail
- From: "Humdinger" <humdingerb@xxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Fri, 13 May 2011 20:36:35 +0200
Hi John!
John Scipione, Wed, 11 May 2011 00:30:38 -0400:
> Found another 80 char limit fail. Please commit.
>
> diff --git src/apps/launchbox/LaunchButton.cpp
> src/apps/launchbox/LaunchButton.cpp
> index d965842..c068eb8 100644
> --- src/apps/launchbox/LaunchButton.cpp
> +++ src/apps/launchbox/LaunchButton.cpp
> @@ -204,7 +204,8 @@ LaunchButton::MouseMoved(BPoint where, uint32
> transit,
> Invalidate();
> }
> }
> - if (!dragMessage || (transit == B_EXITED_VIEW || transit ==
> B_OUTSIDE_VIEW)) {
> + if (!dragMessage
> + || (transit == B_EXITED_VIEW || transit == B_OUTSIDE_VIEW)) {
> if (fAnticipatingDrop) {
> fAnticipatingDrop = false;
> Invalidate();
I'm not sure about that, because right now it's so handsomely
symmetrical to the if statement above it...
That one itself it one character above 80, but I'll let the real devs
decide these aethetics. :)
(The 2nd line of your change would also need a tab, right?)
Regards,
Humdinger
--=-=--=-=--=-=--=-=--=-=--=-=--=-=--=-=--=-=--=-
Deutsche Haiku News - Haiku Gazette
http://haiku-gazette.blogspot.com
Other related posts:
