[haiku-development] Re: [Haiku-commits] r21394 - in haiku/trunk: headers/os/interface src/kits/interface
- From: "François Revol" <revol@xxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Wed, 13 Jun 2007 09:39:04 +0200 CEST
> > > > -1, if there's unnecessary spacing in case none of the items
> > > > controls a
> > > > submenu. Otherwise I'd like to see it.
> > >
> > > As I said in the other mail, there IS unnecessary spacing, since
> > > the
> > > menuitems can't know if the menu has some items with a submenu or
> > > not.
> > > I'll try to come up with some solution to this, though.
> > >
> >
> > Ok, I made it, although I don't know if it's a nice solution:
> > I added a fSubmenus member to BMenu, which is checked from
> > BMenuItem.
> > I'll post a screenshot soon. (although you can check by yourself,
> > of
> > course).
>
> Here's the screenshot (I also fixed the problem reported by Jon and
> Jonas):
> http://burton666.neoni.net/workspace/upload/shots/current.png
>
> I won't touch them for a couple of hours, at least, so feel free to
> fix eventual other issues :)
>
I just hope it doesn't break existing code. I'm sure at least once I
had to substract those spaces in custom MenuItem classes... if those
vanish it will look quite ugly.
François.
Other related posts:
