2008/2/8, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>: > > Andreas Färber <andreas.faerber@xxxxxx> wrote: > > Of course there can be exceptions to this, where a project doesn't > > stick to such best practice rules, but I'm pretty sure most "high > > quality" projects don't want to have new #defines introduced for > > Haiku > > with no evident benefit. > > Sure, but for example networking code heavily needed customizations for > BeOS - this will no longer be the case for Haiku; in that case it's > better to specifically check for BeOS, or against Haiku. > > > The only tricky thing I've encountered was in apr(-util?) where BEOS > > was used to conditionally define a prototype for strerror_r because > > it > > was implemented in libroot but not present in their headers. There > > I'll have to look into a new define, but I don't see the point in > > replacing BEOS with BEOS || HAIKU, it's much easier to define both > > and > > only use #if defined(BEOS) && !defined(HAIKU) or similar only where > > needed. > > Yes, and Haiku's GCC still defines both __BEOS__, and __HAIKU__ for > that reason. > > > We can still do a full code review once we have the self-hosting set > > of tools working on Haiku. > > If we don't actually port the tools, we could also just use BeOS > binaries, though :-) > > Bye, > Axel. > > > I'm way ahead of you :) .I'm already working on adding haiku as a platform for Firefox, Only the ifdefs are left of the problems I know of. While your suggestions are good, they were already used when appopriate even before. There are unfortunatly still a lot of places where cases depend on the arch returned. Anyway that was not my point. My point was that most porters that try right now to do a configure under gcc4 will, if they are not careful, end up building for a platform called haiku. This would probably fail, but it may also skip beos-code and use defaults instead. The gcc4 build will probably not correspond to it's gcc2 counterpart due to this. These hidden dangers would be nice to have documented somewhere and how to solve them (configure hacking..). -- Fredrik Holmqvist Chaordic: things that thrive on the edge of chaos with just enough order to give them pattern, but not so much to slow their adaptation and learning.