[haiku-development] Re: Commit access for Andreas Färber

Stephan Assmus <superstippi@xxxxxx> wrote:
> So either way, you are blocking someone from becoming a new 
> contributor. The 
> kernel is critical, I agree, but you and Axel don't always make 
> perfect 
> commits either. For example, I am still seeing file corruption 
> regularily, 
> and initially the regressions after the pretty stable kernel of r32724 
> (?) 
> were much worse. Everyone introduces regressions from time to time, 
> it's all 
> a work in progress.

Introducing regressions has little to do with code quality, though 
(more with the complexity of the existing code).
In any case, I had little to complain about the changes Andreas 
proposed to include in the generic kernel code.

Even if Andreas would hack the PPC port together, and only barely get 
it to work on his machine, I fail to see the damage he would cause by 
doing so. And honestly, I don't think he would do that bad anyway.

Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> Nope, my point is exactly that I don't have the time and motivation 
> to 
> review all patches in a timely manner, which is why the "commit first, 
> maybe review later" approach will probably result in a lot of code 
> not 
> being reviewed throroughly at all. Unless you intend to do that, that 
> is.

I will certainly read through his patches that affect generic kernel 
code (as always), and I would also skim over his PPC patches. I just 
don't have the time to work deeply on the subject to be able to really 
judge what he is doing in many cases; I would just trust him that he 
takes the right direction in most of the things.

Bye,
   Axel.

Other related posts: