On Thu, Dec 29, 2011 at 6:00 PM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx
<mailto:axeld@xxxxxxxxxxxxxxxx>> wrote:
The point is that this feature does not belong into BMenu. Scrolling
can be implemented in a number of ways, and it's a feature that has
nothing to do with a BMenu itself. Putting too much unrelated
functionality into a single class is bad design, and makes
complicated code that cannot be re-used easily.
See QMainWidget for an example of bad class design: while it can be
a good idea to have a convenience class that bundles existing
functionality, it's just bad to have it wired all into one class
that you cannot use in other contexts (like its dock).
If the code to do menu scrolling doesn't belong in BMenu perhaps it
could be moved to its own class derived from BView, for sake of argument
let's call it BInlineScrollView, and then make BMenu derive from that
class instead of BView.
Besides that, we should switch to a BScrollBar instead of the not so
useful scroll buttons, as has been pointed out already.
No, as I already mentioned, scrollbars take up space in the wrong
dimension so won't work.
