[haiku-development] Re: Are there yet another seat in our Boat? (commit access proposal for Jorma Karvonen)

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sat, 05 Feb 2011 17:02:12 +0100

Siarzhuk Zharski <zharik@xxxxxx> wrote:
> I have spent my yesterday evening in applying and checking a dozen of 
> patches from Mr. Karvonen.  Please look into changeset 40357 

I would probably have only taken you half an hour if it had been 
compiled in a single patch, and were attached to a single ticket.
I would be in favour to only have a single ticket for all translator 
localization, etc. - those are all mini patches that just do more work 
for everyone involved when they are spreaded over so many tickets.

> (http://dev.haiku-os.org/changeset/40357) for details. I found his 
> changes a good enough to think about welcoming you into discussion 
> about 
> the possibility of getting him the commit access.

While I appreciate his enthusiasm and the work he has done so far, I 
don't think he should be given access yet; past patches have shown that 
many of them couldn't be applied as is, as they translated things that 
shouldn't be translated, or components that shouldn't be translated 
(like app_server debug output).
I would rather keep the status quo to have someone else to look over 
his patches before they got applied.
So my vote would be -1 - and please don't take this personally, Jorma, 
I really appreciate what you are doing!

Bye,
   Axel.


Other related posts: