[haiku-development] Re: ATA stack testing

Michael Lotz <mmlr@xxxxxxxx> wrote:

> On Tue, 28 Apr 2009 18:39:27 +0200 (CEST), Marcus Overhagen wrote
> > I made a couple of changes to the ata stack and the ide_adapter, 
> > because it wouldn't work on my ICH9 based core2quad at all.
 
> moving from the ide_* to the ATA_* variables and such. So I don't really
> agree with the ATA_STACK define (and I obviously hate that super-ugly i-RAM
> hack...).
I agree, the define is ugly. Perhaps it would have been better to create a copy
of the ide_adapter and modify that one. Going forward with reworking it into
ata is certainly a good thing, and I won't interfear with that. 

> > ALso, whats the general opinion about switching from ide to ata
> > stack soon?
> 
> Axel reported that his Eee wouldn't boot anymore with the ata bus_manager and
Oh that is bad. Is KDL still working?

> configurations). I haven't checked your further changes yet though, but don't
> see why they should introduce any problems.

Well. I think the clearing of BM interrupt bit in the interrupt handler has a 
lot
of unwanted side effects. Although I think its the only correct way to 
acknowledge
the interrupt, at least the silicon_image_3112 is now completely broken.
I think I should just restore ide_adapter.cpp from svn history, and apply the 
changes
to copied source file. I can do so on Wednesday evening, unless you want 
something
else.

> As mentioned I originally planned to continue reworking the rest of the ATA
> stack adapting ide_adapter to ata_adapter removing PIO interrupt handling as
> you did now and also review the drivers that use the ide_adapter. Then finally
My intention certainly wasn't stopping your work. I just tried doing small 
changes
to get it working on my system.

regards
Marcus

Arcor.de Gaming Area - kostenfrei daddeln bis der Arzt kommt!
Jetzt checken und aus über 80 Spielen wählen!
http://www.arcor.de/footer-gaming/

Other related posts: