[haiku-commits] Re: r42860 - haiku/trunk/src/add-ons/kernel/drivers/ports/usb_serial

> Could you, please look on source of my BeOS usb_serial at
> http://sis4be.cvs.sourceforge.net/viewvc/sis4be/usb_serial/?  It also
> had support of cp2101 USB-to-UART (silabs.c and silabs.h) 

Code looks quite similar. I noticed I forgot to write the close function, so 
the uart will stay on.

> and a bit more
> longer list of supported devices  (driver.c lines 90 - 472) I have
> harvested some years ago. Probably some info can be usefull for you too. ;-)

Well, my device works, and that's enough for me so far. If someone needs 
another one, please ask :)

> > Added: haiku/trunk/src/add-ons/kernel/drivers/ports/usb_serial/Silicon.cpp
> 
> May be the CP210x.cpp or SiliconLabs.cpp base name will be more
> descriptive here?

May be better, yes.

> What is the reason to put this requests enumeration into private section
> of the class declaration? Anyway nobody can use it outside
> implementation of this class. I found a bit more clear way to move it
> completely into Silicon.cpp where it is only used.

The writeConfig method takes this enum type as a parameter, so it needs to be 
declared with the class. I don't know if it's possible to declare an enum in 
a class and define it elsewhere ?

> 
> Thank you for taking the time to finalize support of this hardware!

Programming all kind of electronics devices through a serial port was one of 
the main reason for me not using Haiku full time. It's not anymore :)

-- 
Adrien.

Other related posts: