[haiku-commits] Re: r42500 - haiku/trunk/src/add-ons/kernel/drivers/network/wimax/usb_beceemwmx

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 26 Jul 2011 20:54:49 +0200

On 26.07.2011 20:36, kallisti5@xxxxxxxxxxx wrote:
+++ 
haiku/trunk/src/add-ons/kernel/drivers/network/wimax/usb_beceemwmx/BeceemDDR.cpp
    2011-07-26 18:36:49 UTC (rev 42500)
@@ -171,6 +171,7 @@
                                default:
                                        return -EINVAL;
                        }

I haven't seen the rest of this, so this might be wrong, but -EINVAL is Linux (where error codes are positive), not Haiku -- so you'll likely return something wrong there. Also, prefer to use Haiku native errors like B_BAD_VALUE in this case.

Bye,
   Axel.


Other related posts: