[haiku-commits] Re: r42477 - haiku/trunk/src/servers/app

  • From: Clemens <clemens.zeidler@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 26 Jul 2011 18:52:12 +1200

On Mon, 25 Jul 2011 19:29:11 +1200, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:


clemens.zeidler@xxxxxxxxxxxxxx wrote:
Log:
Remove another assert that fails. In this case the access from ServerApp is
fine.

Could you please not do that? Instead, a better way of handling this issue is introducing an assert that only works in debug mode.

it does

In case of Workspace, the Desktop has to be locked in the constructor, as the index might not actually exist; and it needs to lock during the lifetime of the Workspace object in order to make sure the window list doesn't change (which this check asserts).

Yes the Desktop is locked but the assert had checked if the window lock is locked...
Think the window list can only be changed when the Desktop is locked?

cheers,
        Clemens

Other related posts: