[haiku-commits] Re: r42413 - in haiku/trunk/src/add-ons: accelerants/radeon kernel/drivers/graphics/radeon
- From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 12 Jul 2011 19:30:05 +0200
Alexander von Gluck wrote:
> On Tue, 12 Jul 2011 17:34:27 +0200, Ingo Weinhold wrote:
> > We should use what most other platforms use, respectively what gcc
> > defines by default for the platform, since that will cause the least
> > surprises for porters.
>
> I am completely fine with that, keep in mind thats is how I did it
> originally in
> http://dev.haiku-os.org/changeset/42408 before the __INTEL__ was
> mentioned to
> me.
You used __x86__, which is *not* defined by our gcc (at least 2.95.3 and
4.4.4). You really have to use __INTEL__ in this case. It certainly wouldn't
harm to also define __x86__ and use that in newer code, but I would not
recommend removing __INTEL__ just for the sake of it.
CU, Ingo
Other related posts:
