[haiku-commits] Re: r42377 - haiku/trunk/src/servers/app

  • From: Clemens <clemens.zeidler@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 11 Jul 2011 10:52:04 +1200

On Sun, 10 Jul 2011 20:00:23 +1200, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:


Ryan Leavengood <leavengood@xxxxxxxxx> wrote:
Do you mean trying to further "componentize" the app_server code and
putting those components into their own directories? It is nice how
the drawing code is separated and it seems like other parts of the
app_server could benefit from that as well.

Yes, that would be the basic idea.

bitmaps
client_server
cursors
decorators
desktop
fonts
screen
workspaces

I wouldn't go into that much detail, as that makes it harder in a few
cases on where to put stuff. "fonts", "bitmaps", and "decorator" alone
would already quite improve the situation.
"client_server" is a bit misnamed IMO, as the code only contains the
server part - it would also not be very convenient to separate
ServerWindow from Window, for example.
Some of the existing stuff might be better placed in "drawing", and a
"utility" sub directory would be worthwhile as well.
It would be my preference to put the main classes (Desktop, Window,
View, Server*, ...) into the main directory, as those fit together
well, and make the core of the app_server.

While the separation might not be perfect without some refactoring,
moving the obvious sources files into the above directories then
changing the Jamfile is a quick fix to maybe make the app_server code
easier to manage.

If someone tackles this, there is also the test app_server Jamfile that
needs to be adapted.


will look into it when if I have time...
        Clemens

Other related posts: