[haiku-commits] Re: r41321 - haiku/trunk/src/apps/powerstatus

kallisti5,


> -               && strcmp(fBatteryExtendedInfo.model_number, "")
> -               && strcmp(fBatteryExtendedInfo.serial_number, "")
> -               && strcmp(fBatteryExtendedInfo.type, "")
> -               && strcmp(fBatteryExtendedInfo.oem_info, ""))
> +               && !strcmp(fBatteryExtendedInfo.model_number, "")
> +               && !strcmp(fBatteryExtendedInfo.serial_number, "")
> +               && !strcmp(fBatteryExtendedInfo.type, "")
> +               && !strcmp(fBatteryExtendedInfo.oem_info, ""))
>

You should check against NULL before you strcmp like this:

&& fBatteryExtendedInfo.model_number != NULL &&
!strcmp(fBatteryExtendedInfo.model_number, "")
&& fBatteryExtendedInfo.serial_number != NULL &&
!strcmp(fBatteryExtendedInfo.serial_number, "")
&& fBatteryExtendedInfo.type != NULL && !strcmp(fBatteryExtendedInfo.type,
"")
&& fBatteryExtendedInfo.oem_info != NULL &&
!strcmp(fBatteryExtendedInfo.oem_info, ""))

or you risk a segmentation fault, unless you already are already checking
somewhere...

John Scipione

Other related posts: