[haiku-commits] Re: r41055 - haiku/trunk/src/apps/showimage

  • From: Clemens <clemens.zeidler@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 21 Mar 2011 11:37:09 +1300

On Mon, 21 Mar 2011 01:53:38 +1300, <superstippi@xxxxxx> wrote:

Author: stippi
Date: 2011-03-20 13:53:38 +0100 (Sun, 20 Mar 2011)
New Revision: 41055
Changeset: https://dev.haiku-os.org/changeset/41055
Added:
   haiku/trunk/src/apps/showimage/ToolBarView.cpp
   haiku/trunk/src/apps/showimage/ToolBarView.h
Modified:
   haiku/trunk/src/apps/showimage/Jamfile
   haiku/trunk/src/apps/showimage/ShowImageWindow.cpp
   haiku/trunk/src/apps/showimage/ShowImageWindow.h
Log:
 * Display a tool bar by default (setting can be toggled in the
   View menu)

Already expressed my toolbar size concerns previously and I think the spacing between the icons is to big / the icons could be a bit smaller. Furthermore, I think it even looks better if the space between the icons is reduced a bit. IMHO the Pe toolbar has a good spacing and icon size. Pe's icons size is (more or less) the default small icon size and should be used everywhere as e.g. deskbar and tracker do. (had the same feeling about the WebPositive toolbar)

Just a small bug: if you leave full screen mode not using the menu the toolbar background is not redrawn (try it with a very small image/ icon)...

Regards,
        Clemens

p.s. Again, I'm all for a space efficient combined menu/toolbar solution after R1. Not sure how to make it good looking and consistent, though. Mock-up's are welcome.

Other related posts: