[haiku-commits] Re: r40933 - haiku/trunk/headers/os/locale

  • From: Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 14 Mar 2011 11:10:49 +0100

Am 14.03.2011 um 09:28 schrieb Stephan Aßmus:

> Am 14.03.2011 07:23, schrieb Michael Pfeiffer:
>> Am 13.03.2011 um 22:29 schrieb Axel Dörfler:
>> 
>>> jonas@xxxxxxxxxxx wrote:
>>>> #define B_TRANSLATE_APP_NAME(string) \
>>>> -  BLocaleRoster::Default()->GetCatalog()->GetString((string), \
>>>> -          B_TRANSLATE_APP_NAME_CONTEXT)
>>>> +  BLocaleRoster::Default()->IsFilesystemTranslationPreferred() \
>>>> +  ? BLocaleRoster::Default()->GetCatalog()->GetString((string), \
>>>> +          B_TRANSLATE_APP_NAME_CONTEXT) : (string)
>>> 
>>> Since the app name should be known to the BRoster already, why not just
>>> add a BLocaleRoster::GetTranslatedAppName()? It wouldn't even need any
>>> argument AFAICT.
>> 
>> 
>> What is an app? AFAIK we are developing Haiku not iOS. ;)
>> Shouldn't it be called application:
>> B_TRANSLATE_APPLICATION_NAME_CONTEXT and GetTranslatedApplicationName
> 
> "App" is an often used abbreviation in the Be API. "app_info", "be_app", ...

@Axel, Clemens, Stephan: Thank you for your answers. Keeping consistency is a 
good and valid point. I think ;)

Bye,
Michael


Other related posts: