[haiku-commits] Re: r40917 - haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn
- From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 11 Mar 2011 15:58:43 -0600
On Fri, 11 Mar 2011 14:17:22 -0700
Alex Wilson <yourpalal2@xxxxxxxxx> wrote:
> On Fri, Mar 11, 2011 at 11:20 AM, <kallisti5@xxxxxxxxxxx> wrote:
>
> > Author: kallisti5
> > Date: 2011-03-11 19:20:57 +0100 (Fri, 11 Mar 2011)
> > New Revision: 40917
> > Changeset: http://dev.haiku-os.org/changeset/40917
> >
> > Modified:
> >
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/InterfacesAddOn.cpp
> >
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/NetworkSettings.cpp
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/NetworkSettings.h
> > Log:
> > implement *basic* network interface Healing action; make
> > fNetworkInterface a pointer so it actually works right
> > Modified:
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/NetworkSettings.cpp
> > ===================================================================
> > ---
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/NetworkSettings.cpp
> > 2011-03-11 16:39:49 UTC (rev 40916)
> > +++
> > haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/NetworkSettings.cpp
> > 2011-03-11 18:20:57 UTC (rev 40917)
> > @@ -41,6 +41,8 @@
> > fName = name;
> > _DetectProtocols();
> >
> > + fNetworkInterface = new BNetworkInterface(fName);
> > +
> > ReadConfiguration();
> > }
> >
>
>
> It looks like fNetworkInterface is leaked, at least, it's not deleted
> in ~NetworkSettings().
ack, good catch.
I will go around and make sure all of my new(s) are deleted properly.
Thanks!
-- Alex
Other related posts:
