[haiku-commits] Re: r40520 - in haiku/trunk/src: add-ons/kernel/drivers/graphics/radeon_hd tests/kits/net/preflet/InterfacesAddOn

Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> Alexander von Gluck<kallisti5@xxxxxxxxxxx> wrote:
> > I know this, but based on your previous comments on my commit
> > that added the style violation in the first place you mentioned:
> >
> >  "Same here, really, great commit! :-/"
> >
> > That sounded like you wanted to avoid smaller commits.  I normally
> > make independent commits for independent code areas.
> > Miscommunication I guess on my part.
>
> What I meant with "really, great commit" was that it
> mostly introduced style violations that I have at least
> mentioned once to you before. I have a hard time
> understanding when someone repeats a mistake that has
> been pointed out previously;
 ...
> I guess I would be a great teacher ;-)

When tempted to comment with irony (or even sarcasm) try instead to
elaborate, somehow, preferrably in a way that is frank and honest
but without a sting, which can be hurtful and counterproductive.

I can only speak for myself, but when the feedback gets ripe with
irony or sarcasm, I just feel like quitting.

Things which may be 'obvious' to you Axel - you use this word from
time to time - may not be as obvious to everyone. I believe you are
in a position to work with code professionally, sharpening your
skills and getting paid for self-improvement in this trade. Have
mercy on non- and semiprofessionals!

(Things which one thinks one has been stated clearly, may come across
as something else. The obviousness of the message, can not simply be
asserted by the sender, but has to be tempered by the correctness
of the receiver's interpretation. Miscommunication can seldom, IMO,
be blamed on just the recipient, especially since perfection does not
exist in this reality. "Every decoding is a new encoding." ;P
Lost in translation, etc)

 ...
> BTW "I cannot implement something I do not know" is a poor
> excuse for not investigating better beforehand. I know that
> our API is currently not as clean as it used to be, but that
> makes it even more important to learn by example (ie. an
> application that makes good use of the layout functionality).

Indeed. Learning the style is not a single read-through but an
iterative process, much like learning a natural language:
hear/speak/read/write.

(Unlike Antonio Banderas in "The 13th Warrior"
http://www.imdb.com/title/tt0120657/
Herger the Joyous: Where did you learn our language?
Ahmed Ibn Fahdlan: I listened! )

When when studying a body of code, perhaps even the style guide,
it is seldom possible to see and absorb all of its properties
all at once. No matter how clean the API is or how clear the
style guide is made it is safe to assume that every new committer
and even older ones, returning ones, will make mistakes.

To aggravate oneself over this in an unhealthy way is bad for
oneself and bad for the project. What good is code quality
if there is no one left to attend to it.

Pardon the rant. Just some old build up tension.

/Jonas.


Other related posts: