[haiku-commits] r40310 - haiku/trunk/src/servers/app

  • From: korli@xxxxxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 28 Jan 2011 20:34:37 +0100 (CET)

Author: korli
Date: 2011-01-28 20:34:37 +0100 (Fri, 28 Jan 2011)
New Revision: 40310
Changeset: http://dev.haiku-os.org/changeset/40310
Ticket: http://dev.haiku-os.org/ticket/6353

Modified:
   haiku/trunk/src/servers/app/ServerWindow.cpp
Log:
Applied patch from stimut (#6353), thanks!
In ServerWindow::_DispatchViewDrawingMessage(), for AS_DRAW_STRING_WITH_OFFSETS,
the string length rather than the number of UTF8 glyphs is used, thus leading
to an app_server crash.


Modified: haiku/trunk/src/servers/app/ServerWindow.cpp
===================================================================
--- haiku/trunk/src/servers/app/ServerWindow.cpp        2011-01-28 19:18:09 UTC 
(rev 40309)
+++ haiku/trunk/src/servers/app/ServerWindow.cpp        2011-01-28 19:34:37 UTC 
(rev 40310)
@@ -2782,7 +2782,7 @@
                        DTRACE(("ServerWindow %s: Message 
AS_DRAW_STRING_WITH_OFFSETS, View: %s "
                                "-> %s\n", Title(), fCurrentView->Name(), 
string));
 
-                       for (int32 i = 0; i < stringLength; i++)
+                       for (int32 i = 0; i < glyphCount; i++)
                                
fCurrentView->ConvertToScreenForDrawing(&locations[i]);
 
                        BPoint penLocation = drawingEngine->DrawString(string,


Other related posts:

  • » [haiku-commits] r40310 - haiku/trunk/src/servers/app - korli