[haiku-commits] Re: r40298 - in haiku/trunk/src/add-ons/translators: bmp ico jpeg

Hi All,

On Wed, 26 Jan 2011 23:58:48 +0100 (CET), korli@xxxxxxxxxxxxxxxx wrote:

Modified: haiku/trunk/src/add-ons/translators/bmp/Jamfile
===================================================================
--- haiku/trunk/src/add-ons/translators/bmp/Jamfile     2011-01-26
22:06:02 UTC (rev 40297)
+++ haiku/trunk/src/add-ons/translators/bmp/Jamfile     2011-01-26
22:58:47 UTC (rev 40298)
@@ -14,8 +14,15 @@
        : true
 ;

+DoCatalogs BMPTranslator :
+       x-vnd.Haiku-BMPTranslator
+       :
+       BMPMain.cpp
+       BMPTranslator.cpp
+       BMPView.cpp
+;
+
 Package haiku-translationkit-cvs :
        BMPTranslator :
        boot home config add-ons Translators ;

-
By the way, the correct MIME signature is required to be in the Data Translation binary resources to let that localization work. At the moment system doesn't load corresponding catalog with syslog message about lack of MIME type in the binary resource. Manual adding correct MIME signature solves the problem. Following patch fixes the problem in my case, but there are some remarks in FileTypes Add-On for example, that "this is add-on but application, so it have no app signature". Another remark above "AddResource" clause that "TODO: Doesn't seem to work." Are there any problems possible? 


Index: Jamfile
===================================================================
--- Jamfile     (revision 40293)
+++ Jamfile     (working copy)
@@ -5,6 +5,8 @@
 UseLibraryHeaders png zlib ;
 SubDirHdrs [ FDirName $(SUBDIR) $(DOTDOT) shared ] ;

+AddResources PNGTranslator : PNGTranslator.rdef ;
+
 if $(HAIKU_GCC_VERSION[1]) = 2 {
        SubDirCcFlags -DPNG_NO_PEDANTIC_WARNINGS ;
 }

Index: PNGTranslator.rdef
===================================================================
--- PNGTranslator.rdef  (revision 0)
+++ PNGTranslator.rdef  (revision 0)
@@ -0,0 +1 @@
+resource app_signature "application/x-vnd.Haiku-PNGTranslator";


--
Kind Regards,
   S.Zharski

Other related posts: