[haiku-commits] Re: r40149 - haiku/trunk/src/apps/bootmanager

  • From: Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 9 Jan 2011 08:07:38 +0100

Am 09.01.2011 um 01:00 schrieb Axel Dörfler:

> Hi Michael,
> 
> Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx> wrote:
>>> +   status_t status = ioctl(fd, B_GET_BIOS_DRIVE_ID, drive, 1);
>>> +   close(fd);
>>> +   return status;
>> Has B_GET_BIOS_DRIVE_ID been implemented? If not, at least it would 
>> explain, why
>> booting now fails after selecting a partition in the boot manager.
> 
> Thanks for looking that up, but that neither has been implemented in 
> the mean time, nor is it the reason for the failure. I've changed the 
> boot manager to use zero as BIOS drive for the boot menu, so that it 
> will always use the correct one for the paritions on the boot drive.
> It will just make it work to boot partitions from other drives once 
> someone implements this. Since it's really only needed for that 
> usecase, I would guess the need for this is rather low, though, with 
> EFI/GPT right around the corner.
> 
>> The screen shows:
>> Loading Haiku
>> read error
> 
> This problem should be fixed with r40167, at least I can now boot my 
> system again, and I see no reason why it shouldn't work for others as 
> well.
> 
>> BTW is seems the "Uninstall" button is always disabled on the first 
>> page
>> in Boot Manager.
> 
> Yes, that's actually caused by a TODO that I did not implement either; 
> ie. the detection of an installed boot menu :-)
> It's just worse now, since it prevents removing the menu (but who would 
> want to do that, anyway, huh?).

Confirmed, the problems are fixed. Thank you.

I think it is problematic that you can now generate invalid 
boot menus with Boot Manager, because it allows you
to select partitions from different drivers (before your changes
only partitions from the first drive could be selected).
Booting from a partition on another than the boot drive won't
work until B_GET_BIOS_DRIVE_ID is implemented.
For a quick fix the list of partitions should show only
the partitions from the target drive selection on the first
Boot Manager page.

- Michael


Other related posts: