[haiku-commits] Re: r40101 - haiku/trunk/src/preferences/virtualmemory
- From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 4 Jan 2011 10:01:52 +0100
2011/1/4 <leavengood@xxxxxxxxx>:
> @@ -21,12 +22,12 @@
>
> static const char* kWindowSettingsFile = "VM_data";
> static const char* kVirtualMemorySettings = "virtual_memory";
> +static const int64 kMegaByte = 1048576;
A computed value is preferred (1024 * 1024).
> private:
> + void SetSwapNull();
> void ReadWindowSettings();
> void WriteWindowSettings();
>
_SetSwapNull() is style conform.
> +class VolumeMenuItem : public BMenuItem {
> + public:
> + VolumeMenuItem(const char* label, BMessage* message, BVolume*
> volume);
> + virtual ~VolumeMenuItem();
> + BVolume* fVolume;
> +};
The destructor seems useless if volume isn't owned.
> + int32 choice = (new BAlert("VirtualMemory", B_TRANSLATE(
Only one space before B_TRANSLATE
> Modified: haiku/trunk/src/preferences/virtualmemory/SettingsWindow.h
> ===================================================================
> --- haiku/trunk/src/preferences/virtualmemory/SettingsWindow.h 2011-01-04
> 01:39:30 UTC (rev 40100)
> +++ haiku/trunk/src/preferences/virtualmemory/SettingsWindow.h 2011-01-04
> 02:13:13 UTC (rev 40101)
> @@ -27,6 +27,7 @@
> private:
> void _Update();
> status_t _GetSwapFileLimits(off_t& minSize, off_t& maxSize);
> + void SetSwapDefaults();
_SetSwapDefaults() is style conform.
Bye,
Jérôme
Other related posts:
