[haiku-commits] Re: r39896 - haiku/trunk/src/servers/notification

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 20 Dec 2010 21:27:59 +0100

Am 20.12.2010 18:31, schrieb philippe.houdoin@xxxxxxxxx:

Author: phoudoin
Date: 2010-12-20 18:31:27 +0100 (Mon, 20 Dec 2010)
New Revision: 39896
Changeset: http://dev.haiku-os.org/changeset/39896

Modified:
    haiku/trunk/src/servers/notification/NotificationView.cpp
Log:
Removed bilinear filter, as it was blurring all icons (and bitmap icons are
already rendered with a filter).


Modified: haiku/trunk/src/servers/notification/NotificationView.cpp
===================================================================
--- haiku/trunk/src/servers/notification/NotificationView.cpp   2010-12-20 
16:25:38 UTC (rev 39895)
+++ haiku/trunk/src/servers/notification/NotificationView.cpp   2010-12-20 
17:31:27 UTC (rev 39896)
@@ -270,7 +270,7 @@
                progRect.top = progRect.bottom - (kSmallPadding * 2) - 
fontHeight;
                StrokeRect(progRect);

-               BRect barRect = progRect;               
+               BRect barRect = progRect;
                barRect.InsetBy(1.0, 1.0);
                barRect.right *= fProgress;
                SetHighColor(ui_color(B_CONTROL_HIGHLIGHT_COLOR));
@@ -326,15 +326,14 @@
                iconRect.right = ix + iconSize;
                iconRect.bottom = iy + iconSize;

-               DrawBitmapAsync(fBitmap, fBitmap->Bounds(),
-                       iconRect, B_FILTER_BITMAP_BILINEAR);
+               DrawBitmapAsync(fBitmap, fBitmap->Bounds(),  iconRect);
        }
This would indicate that iconRect != fBitmap->Bounds(). The scaler is never used if the scale is 1. Regardless of the flag. You should have replaced the blurred look for a equally bad look with missing or repeated pixels. 

Best regards,
-Stephan

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 12-2010