[haiku-commits] Re: r39280 - haiku/trunk/headers/os/locale

> "Adrien Destugues" <adestugu@xxxxxxxxx> wrote:
> > >  #else    /* B_COLLECTING_CATKEYS */
> > > +// TODO: why define them here? Since we obviously control the 
> > > preprocessor, > we
> > > +// could simply always include a certain file that defines them; 
> > > this doesn't
> > > +// really belong into a public header.
> > These are needed by the collectcatkeys tool even outside of Haiku's 
> > own 
> > build tree, for any localized application. So why should people 
> > reinvent the wheel in their own buildsystem, when it can be 
> > included 
> > here ?
> 
> I probably don't know how the collectcatkeys tool work then.
> Does it not only use the preprocessor on them itself? If it does, it 
> could simply add its own include.

collectcatkeys itself doens't actually do anything, cpp must be called 
first to preprocess the files. Using a separate include is possible, 
but this one would still have to be public, that is, included in the 
development tools package in some way. It could be moved out of the 
usual public header space.

However, source files always include this file, and we should still 
make sure that the macros aren't defined by this one instead of the 
other include specified on cpp command line. So we would still need a 
#if block around them.

-- 
Adrien.

Other related posts: