[haiku-commits] Re: r39225 - haiku/trunk/src/add-ons/media/plugins/ffmpeg
- From: "Stephan Assmus" <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 31 Oct 2010 13:24:26 +0100
Hi,
Von: "Clemens Zeidler" <clemens.zeidler@xxxxxxxxxxxxxx>
> Am 31.10.2010, 23:07 Uhr, schrieb Stephan Assmus <superstippi@xxxxxx>:
> >> > Modified:
> >> > haiku/trunk/src/add-ons/media/plugins/ffmpeg/AVFormatReader.cpp
> >> > Log:
> >> > Use some more meaningful names in the metadata message. Used the
> names
> >> > from the id3v2.c ffmpeg file. Stippi does this really fix the TODO?
> >>
> >> Stephan, any plans to add a SetMetaData method? Can ffmpeg write tags?
> >
> > I am not sure if it can write tags outside the context of encoding a
> > file. A SetMetaData method would be fine. The use of a BMessage as the
> > container was a quick idea. Do you think we need something else?
> >
>
> I think the BMessage is fine. For example, I'm not sure if the current tag
> list is complete there is the year tag missing in the ffmpeg list but I
> still found the year tag in the message.
Must come from somewhere else then, perhaps grep the code? Probably best to
grep the code for usage of the FFmpeg meta data API.
> > This is certainly what I had in mind. We just need to make sure that we
> > rename tags from other FFmpeg plugins as well. (If there are any and if
> > >they divert from the "standard" we set.) Perhaps check the Vorbis
> > plugin what names are used there.
>
> What do you mean? grep in /haiku/trunk/src/add-ons/media only gives a
> result for GetMetaData in AVFormatReader.cpp. Isn't it a central wrapper
> for all plugins?
Sure, I mean other clients (FFmpeg demuxers) of the FFmpeg internal meta data
API. We just need to make an effort to map all different names used in FFmpeg
for the same thing to the same tag name in the BMessage during conversion. If
for example the FFmpeg Vorbis plugin were to use "auth" and the FFmpeg MP3
plugin uses TATH or whatever it was, then we need to make sure it always ends
up as "author" in the BMessage readable through our own API. My goal is just
that we insulate Haiku applications from the actual container format and
different naming conventions for the same thing.
Best regards,
-Stephan
Other related posts:
