[haiku-commits] Re: r39105 - haiku/trunk/src/apps/showimage

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 24 Oct 2010 10:26:20 +0200

Am 24.10.2010 02:39, schrieb DarkWyrm:
* Removed all selection copy/move/cut code. This just doesn't belong
into an
image viewer.
* Selections are now changed using the tertiary mouse button, or when
you press
the command or control modifiers. Instead, the image will now be moved
around
with the left button.
I have major objections to these changes. Please revert them. The others
are quite sensible, however.

Just because you think "clipboard operations just don't belong" in an
image viewer, that doesn't mean that they have to be completely done
away with. They don't add complexity to the application in a way which
interferes with the main task. I also prefer that my image viewer allow
me to perform simple tasks such as these. Although this could be said
for your change with Invert earlier, it is an edge-case use. These, I
would argue, are not -- especially copy.

If you looked more closely into the changes, you would have realized that "clipboard" operations are not removed at all. The useless and confusing feature to make a selection in the image and then drag that selection somewhere else in the image was removed. Dragging the selection to Tracker is still supported as before. And that feature actually makes sense. I have serious doubts that you or anyone else used the *editing* features. They worked so awkward that they couldn't be used even for the very limited use-cases for which they could have applied. One reason for that is that you can't comfortably modify the selection rectangle after you have initially made it. The selection is useful for cropping, but why would you move *rectangular* parts of images within themselves?

In the major applications that I have used, the left mouse is for
selecting and the middle is for moving. This is backwards and completely
unacceptable.

Yes, often the middle mouse button is used for panning. But that's because panning is often not the primary action. In Showimage however it should be the primary action. However, I could agree to revert that part regardless.

Quite some time ago, I got into some (sometimes heated) discussions when
I made usability changes arbitrarily without at least asking. Same goes
here only I'm not the one making them.

We really need some sort of reasonably lightweight process for handling
these kinds of changes.

IMHO you are getting angry without looking closer into the changes actually made. There are tons of problems with ShowImage before it becomes more useful. Removing misfeatures is a good start.

Best regards,
-Stephan


Other related posts: