[haiku-commits] Re: r38354 - in haiku/trunk: headers/private/graphics/intel_extreme src/add-ons/accelerants/intel_extreme

Andreas Färber <andreas.faerber@xxxxxx> wrote:
> Some style questions:

Those might be better placed in haiku-development, usually, but well,
there is always a next time :-)

> * The copyright notices show all kinds of variations with regards to
> commas and points. Is this left as creative freedom to the authors?
> Or
> is there a particular reason why the Coding Guidelines show plain
> email adresses rather than angle-bracketed ones? (which many files do
> have) In some text editors this decides whether they're shown
> clickable.

I personally don't like the <> form too much, but we never agreed on
anything in particular here. I would rather avoid making it even easier
for some robot to catch the addresses listed here.
I also leave out the "All rights reserved" as it doesn't serve any real
purpose anymore, AFAIK.

> * Is there an unwritten rule for ordering the #includes within the
> domain-specific block in the bootloader/kernel? Guidelines say they
> should be sorted alphabetically within the group, but it seems that
> often <boot/platform.h> is first. Also, should files generally precede
> directories or should they be mixed alphabetically?

You must remember that the coding style has been
changed/adapted/completed/improved over time, and that not all sources
have been adapted to it yet. One usually does that when intending to
work on a file, or when stumbling over some violations.

The first include should be the one header matching the source file, if
any. The rest according to the guidelines, and directories are usually
be mixed alphabetically, although I don't think we've talked about that
detail in particular when deciding the status quo.

Bye,
   Axel.


Other related posts: