[haiku-commits] Re: r37275 - in haiku/trunk: headers/os/opengl src/kits/opengl

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 28 Jun 2010 10:12:04 +0200

On 2010-06-28 at 10:07:36 [+0200], Philippe Houdoin 
<philippe.houdoin@xxxxxxxxx> wrote:
> > Not having access to R5, what is the definite answer in this case?
> 
> It says char*, unfortunately.
> Seems like the OpenGL kit didn't receive the same consistency check
> than the Interface Kit, most probably because GLView is one of the few
> built-in views that are not hosted in Interface Kit...
> 
> > And
> > If it is indeed not a const char* in R5, will making it a const char*
> > break binary compatibility?
> 
> Yep. The BGLView constructor GCC signature will not be the expected
> one, which break the binary compatibility.
> I know, I did the char* -> const char* move too myself a few months or
> years ago before reverting it just a few hours later after people
> (maybe even the same ones, hi Stephan*s* !) shown me why.

Don't remember such an instance, but didn't Be itself change a char* to 
const char* in one of the BMessage methods for Dano and that didn't break 
binary compatibility? I thought "const" in particular is purely a hint for 
the compiler regarding what is allowed and what isn't, but I have no clue.

Best regards,
-Stephan

Other related posts: