[haiku-commits] Re: r37275 - in haiku/trunk: headers/os/opengl src/kits/opengl

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 28 Jun 2010 09:15:21 +0200

On 2010-06-28 at 08:41:53 [+0200], Wim van der Meer 
<wpjvandermeer@xxxxxxxxx> wrote:
> On Mon, Jun 28, 2010 at 2:47 PM, Stefano Ceccherini
> <stefano.ceccherini@xxxxxxxxx> wrote:
> > 2010/6/27  <wpjvandermeer@xxxxxxxxx>:
> >> Author: wim
> >> Date: 2010-06-27 11:11:17 +0200 (Sun, 27 Jun 2010)
> >> New Revision: 37275
> >> Changeset: http://dev.haiku-os.org/changeset/37275/haiku
> >>
> >> Modified:
> >>   haiku/trunk/headers/os/opengl/GLView.h
> >>   haiku/trunk/src/kits/opengl/GLView.cpp
> >> Log:
> >> Compiler warning fix.
> >>
> >> -               ulong options)
> >> +BGLView::BGLView(BRect rect, const char* name, ulong resizingMode, 
> >> ulong mode,
> >> +       ulong options)
> >>        :
> >>        BView(rect, name, B_FOLLOW_ALL_SIDES, mode | B_WILL_DRAW | 
> >>        B_FRAME_EVENTS),
> >>                //  | B_FULL_UPDATE_ON_RESIZE)
> >>
> >
> > I think that this breaks binary compatibility.
> >
> 
> You may be right.
> This change makes the function consistent with BeBook though, so on
> the other hand it might improve binary compatibility.

Sometimes the BeBook got it wrong. The R5 header is the definite answer. :-)

Best regards,
-Stephan


Other related posts: