[haiku-commits] Re: r36307 - haiku/trunk/src/preferences/locale

Hi Adrien,

2010/4/15  <pulkomandy@xxxxxxxxx>:
> +               }
> +       } else BOutlineListView::MessageReceived(message);
> +}

The MessageReceived call should be on its own line.

> +                       if (BView* v = new BView(dragBitmap->Bounds(), 
> "helper",
> +                                                                        
> B_FOLLOW_NONE, B_WILL_DRAW)) {

Why checking the view like this ?

> +       } else {
> +               BOutlineListView::MouseMoved(where, transit, msg);
> +       }

A single statement doesn't need surrounding parenthesis.

>
> Added: haiku/trunk/src/preferences/locale/LanguageListView.h
> ===================================================================
> --- haiku/trunk/src/preferences/locale/LanguageListView.h                     
>           (rev 0)
> +++ haiku/trunk/src/preferences/locale/LanguageListView.h       2010-04-15 
> 17:48:31 UTC (rev 36307)
> @@ -0,0 +1,61 @@
> +#ifndef __LANGUAGE_LIST_VIEW_H
> +#define __LANGUAGE_LIST_VIEW_H

This file lacks a copyright header.

> +
> +
> +#include <OutlineListView.h>
> +#include <StringItem.h>
> +#include <String.h>
> +
> +
> +class LanguageListItem: public BStringItem
> +{

> +class LanguageListView: public BOutlineListView
> +{

The brace goes at the end of the previous line.

Bye,
Jérôme

Other related posts: