[haiku-commits] Re: r36010 - in haiku/branches/developer/zooey/posix-locale/src/system: kernel/lib libroot/posix/locale

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 30 Mar 2010 22:09:07 +0200

zooey@xxxxxxxxxxxxxxx wrote:
> first steps towards posix locale support:

Uh, nice :-)
Some nitpicking following:

> +const char*
> +LocaleBackend::LocaleAccordingToEnvironment(int category)
> +{
> +     const char* locale = getenv("LC_ALL");
> +     if (!locale || !*locale) {
> +             switch(category) {

Missing space after "switch".

> +extern "C" char *
> +setlocale(int category, const char *locale)

Inconsistent asterisk use.

Bye,
   Axel.


Other related posts: