zooey@xxxxxxxxxxxxxxx wrote: > first steps towards posix locale support: Uh, nice :-) Some nitpicking following: > +const char* > +LocaleBackend::LocaleAccordingToEnvironment(int category) > +{ > + const char* locale = getenv("LC_ALL"); > + if (!locale || !*locale) { > + switch(category) { Missing space after "switch". > +extern "C" char * > +setlocale(int category, const char *locale) Inconsistent asterisk use. Bye, Axel.