[haiku-commits] Re: r34140 - haiku/trunk/src/apps/screenshot
- From: Fredrik Modèen <fredrik@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 20 Nov 2009 10:17:57 +0100 (CET)
> Fredrik Modèen <fredrik@xxxxxxxxx> wrote:
>> > Can you elaborate on that? It looks a bit like you have hard-coded
>> > values
>> > that depend on the runtime configuration of currently installed
>> > translators.
>> Yes I have and if there are a better way please tell me :)
>> I actually had int values (taken with a printf) instead of the define
>> values like B_PNG_FORMAT.
>
> You are really serious? How do you think this could have ever worked
> for real?
It did work, or if I moved to the define before I tested it, don't remember.
> Please, if you are unsure about something, don't commit completely
> broken stuff like this -- just ask how one could do it. No one would
> mind to answer a question like this.
Right but to ask a question one need to know what to ask for :)
>
> You could have a look at src/bin/translate.cpp which more or less solves
> the same thing a bit more intelligently and flexible.
Will have a look there.. thanks.
>
> Bye,
> Axel.
>
>
>
--
MVH
Fredrik Modèen
Other related posts:
