[haiku-commits] Re: r34140 - haiku/trunk/src/apps/screenshot
- From: Fredrik Modèen <fredrik@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 20 Nov 2009 10:56:33 +0100 (CET)
> Fredrik Modèen <fredrik@xxxxxxxxx> wrote:
>> >> Yes I have and if there are a better way please tell me :)
>> >> I actually had int values (taken with a printf) instead of the
>> > > define
>> >> values like B_PNG_FORMAT.
>> > You are really serious? How do you think this could have ever worked
>> > for real?
>> It did work, or if I moved to the define before I tested it, don't
>> remember.
>
> But you know that translators aren't fixed, right? You can add and
> remove translators as you choose, so while this solution would have
> worked in your particular setup (or a clean Haiku image), it's still a
> pretty much brain dead solution. Sorry for being harsh, but I'm really
> a bit appalled.
Yes I know. I Didn't thought about how to handle if a translator didn't
exist. I thought those things was already taken care of in the original
code, but perhaps one should,'t taken things for given :)
and now I know a new word "appalled"
Perhaps a error message should be shown stating that a translator for the
given format don't exist before trying to make a ScreenshotWindow?
>
> Bye,
> Axel.
>
>
>
--
MVH
Fredrik Modèen
Other related posts:
