[haiku-commits] Re: r33814 - haiku/trunk/src/servers/app

Philippe Houdoin <philippe.houdoin@xxxxxxxxx> wrote:
> On Thu, Oct 29, 2009 at 11:14 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
> > wrote:
> > We can put it in a branch if you like, but this isn't ready for
> > trunk.
> Okay, I take notice. I'll create a branch for it and try to
> eventually
> fix main issues before merging back into trunk. Me or whoever want
> to.

Thanks! Please make sure my coding style fixes aren't lost on the way.

> I didn't though it was necessary, I was wrong.

A thorough review should take place before applying something like
this. I wrongly assumed that those that advocated putting it into trunk
would have done this already.
Thanks to SVN it's not a big issue anyway.

> Which lead me to ask if it's not the time to clarify the purpose of
> trunk and the commit policy there. After alpha1, if trunk is not
> anymore the main coding tree where changes, even pending ones, happens
> but is supposed to be a little more stable, policed source tree, then
> branches should be promoted far more often, no?

There can always be changes that break something, but it's not a good
idea to put something as complex and unfinished as this into a
component as crucial and complex as the app_server.
While trunk might be broken from time to time, and even unusable, we
should always try to not commit something as complex and unfinished
that affects just everyone.
For this patch, it's a lot of work to get it right.

I'm not sure if Christof or Hong are reading this list - I'll write a
mail to haiku-development explaining the situation, and what has to be
done.

Bye,
   Axel.

Other related posts: