[haiku-commits] Re: r33814 - haiku/trunk/src/servers/app

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 29 Oct 2009 11:14:12 +0100

philippe.houdoin@xxxxxxxxx wrote:
> Log:
> Applied Stack & Tile patch by Hong Yul Yang, formely by Christof 
> Lutteroth.

Did you actually review that patch or anyone else?
Besides a gazillion coding style issues, it doesn't seem to be ready 
for a component as crucial as the app_server at all. No memory 
allocation checks, no nothrow, use of BList for no reason, clobbers the 
code all over the place instead of being a bit more contained, 
allocates memory when you shouldn't.

I will revert that change again. We can put it in a branch if you like, 
but this isn't ready for trunk.


Other related posts: