[haiku-commits] Re: haiku: hrev44503 - in src: kits/tracker preferences/filetypes

  • From: Philippe Saint-Pierre <stpere@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 9 Aug 2012 10:26:25 -0400

> I haven't read the code your changeset modified, so just a general comment 
> with respect to your reply: There are two different classes that can be used 
> to set icons etc. on files: BNodeInfo and BAppFileInfo. The former only sets 
> attributes, the latter (by default) also sets the resources. BAppFileInfo is 
> only meant to be used with file formats that can contain resources 
> (executables, shared libraries, and the like). For text files (and other 
> "data" files) BNodeInfo must be used. So either the code is using the wrong 
> class or a text file should never get there.
>
> CU, Ingo

Hi Ingo,

In that case, there is no distinction made on the file type, and it's
using BAppFileInfo.  Would you advise switching to BNodeInfo?  To add
more context, this is the use case where a user assigns a specific
icon to an entry.

Philippe

Other related posts: