[haiku-commits] Re: haiku: hrev44503 - in src: kits/tracker preferences/filetypes
- From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 09 Aug 2012 16:22:08 +0200
Philippe Saint-Pierre wrote:
> On Thu, Aug 9, 2012 at 6:17 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> > Am 09.08.2012 07:29, schrieb stpere@xxxxxxxxx:
> >
> >> ff163a8: FileTypes preflet: save HVIF icons as attributes only
> >> Previously, changing a file's icon was creating both an attribute
> >> and a ressource, now it only saves it as an attribute
> >> i.e. don't change the file content.
> >
> > Is there a specific reason for this change?
>
> Indeed, I was testing it on text/plain files, and the ressource was
> appearing directly as file content, seemingly as garbage. Maybe I'm
> mistaken, but I don't think Tracker is looking for icons in ressource
> (but I admit I might be mistaken), so I figured it wouldn't do harm to
> only save it in an attribute.
I haven't read the code your changeset modified, so just a general comment with
respect to your reply: There are two different classes that can be used to set
icons etc. on files: BNodeInfo and BAppFileInfo. The former only sets
attributes, the latter (by default) also sets the resources. BAppFileInfo is
only meant to be used with file formats that can contain resources
(executables, shared libraries, and the like). For text files (and other "data"
files) BNodeInfo must be used. So either the code is using the wrong class or a
text file should never get there.
CU, Ingo
Other related posts: