On Wed, Jul 25, 2012 at 1:52 PM, Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote: > 2012/7/25 <humdingerb@xxxxxxxxxxxxxx>: >> + // start from the beginning of text >> + fTextView->Select(0,0); >> + >> + int32 start, finish; >> + >> + // iterate occurences of findThis without wrapping around >> + while (_Search(findThis, caseSensitive, false, false, false)) { >> if (first) { >> _UpdateCleanUndoRedoSaveRevert(); >> first = false; >> } >> - int32 start, finish; >> + >> fTextView->GetSelection(&start, &finish); > > There was no need to move start and finish declarations outside out of the > loop. And while fixing that please make them one per line as in: int32 start; int32 finish; John Scipione