[haiku-commits] Re: haiku: hrev43773 - in src: apps/activitymonitor kits/interface

On 02/23/2012 01:12 AM, stpere@xxxxxxxxx wrote:
d63b75f: Outline of labels/strings drawn to desktop

Sorry that I missed the opportunity to reply to your request for comments earlier; I meant to, but time is flying these days.

I have pretty much the same concerns Stippi has already mentioned, though, so there are only a few coding style issues left to be pointed at:

-BControlLook::BControlLook()
+BControlLook::BControlLook():
+       fCachedOutline(false),
+       fCachedWorkspace(-1)

The ':' goes to the next line, all alone.

+       rgb_color       low;
+       rgb_color       color;
+       rgb_color       glowColor;

Thunderbird might be the source of it, but the variables shouldn't be indented by a tab.

+       // check if the drawing occurs on the desktop
+       if (isDesktop) {
+               
+               if (fCachedWorkspace != current_workspace()) {
+
+                       int8 indice = 0;

Two superfluous blank lines. "Indice" isn't English, try "index" :-)

+                       int32 mask;
+                       bool tmpOutline;
+                       while 
(fBackgroundInfo.FindInt32("be:bgndimginfoworkspaces",
+                                       indice,&mask) == B_OK
+                               &&  
fBackgroundInfo.FindBool("be:bgndimginfoerasetext",
+                                       indice,&tmpOutline) == B_OK) {
+
+                               if (((1<<  current_workspace())&  mask) != 0) {

And another one.

+                       view->SetDrawingMode(B_OP_ALPHA);
+                       view->SetBlendingMode(B_CONSTANT_ALPHA, 
B_ALPHA_OVERLAY);
+                       // Draw glow or outline
+                       if (glowColor == kWhite) {
+                                       font.SetFalseBoldWidth(2.0);
+                                       view->SetFont(&font, 
B_FONT_FALSE_BOLD_WIDTH);

This might be Thunderbird again, but the indentation looks wrong.

+++ b/src/kits/tracker/BackgroundImage.cpp
@@ -36,6 +36,7 @@ All rights reserved.
  //

  #include<Bitmap.h>
+#include<ControlLook.h>
  #include<Node.h>
  #include<TranslationKit.h>
  #include<View.h>
@@ -96,6 +97,10 @@ BackgroundImage::GetBackgroundImage(const BNode *node, bool 
isDesktop)
                } else
                        break;

+               if (be_control_look != NULL&&  isDesktop) {
+                       be_control_look->SetBackgroundInfo(container);
+               }
+

Superfluous curly braces.

Bye,
   Axel.

Other related posts: