[haiku-commits] Re: haiku: hrev43773 - in src: apps/activitymonitor kits/interface

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 23 Feb 2012 14:45:34 +0100

Hi,

Am 23.02.2012 13:23, schrieb Philippe Saint-Pierre:
So basically I would have 3 flags, B_OUTLINE_AUTO, B_OUTLINE_GLOW and
B_OUTLINE_SHADOW?  Sounds fair.

Ah yes, you probably need AUTO as well. As for names... maybe B_LABEL_DECORATION_... or B_LABEL_EFFECT_...

I too was concerned about some design choices, which is why I requested comments
first in the ML ;-)

Yes I know, really sorry about that. I intended to reply, but then forgot and now I was reading the commit mail when I had some time to reply. Hopefully, my proposed changes would mainly mean to copy and paste stuff around, no actual changes in functionality.

I also noticed some places where BControlLook.h is only conditionnally
included (#ifdef __HAIKU__..), ActivityMonitor comes to mind.  But then
be_control_look was already mentionned elsewhere in the sources.  I
wonder if I should #ifdef those calls to, just in case.

It's for when the program was once intended to compile on BeOS, but mostly the code will not compile for BeOS regardless these days. You can just remove those, I guess.

Best regards,
-Stephan

Other related posts: