[haiku-commits] Re: BRANCH mmadia-github.separate-build-environment - headers/build/os/support headers/build/config_build src/build/libroot

  • From: "Ingo Weinhold" <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 03 Aug 2012 01:53:08 +0200

Matt Madia wrote:
> On 8/1/12, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> > On 2012-08-01 at 03:49:12 [+0200], mmadia-github.separate-build-environment
> > <community@xxxxxxxxxxxx> wrote:
> 
> >> diff --git a/headers/build/config_build/types.h
> >> b/headers/build/config_build/types.h
> >> index 960e1ce..53da55d 100644
> >> --- a/headers/build/config_build/types.h
> >> +++ b/headers/build/config_build/types.h
> >
> > [...]
> >> +typedef _HAIKU_BUILD_FEATURE_int8 __haiku_build_haiku_std_int8;
> >
> > Yep.
> >
> >> +/* map the macros/types, if not building the libroot mapper functions */
> >> +
> >> +#ifndef _HAIKU_BUILD_LIBROOT_FUNCTION_WRAPPER
> >> +
> >> +typedef __haiku_build_haiku_std_int8 __haiku_std_int8;
> > [...]
> >
> > Can be omitted. There's no need to conditionally define __haiku_std_int8,
> > since it should be used only in headers (where you can use
> > __haiku_build_haiku_std_int8), but never in client code. The same goes for
> > the macros defined in this header.
> 
> Could you rephrase that?
> 
> Do you mean to omit the single {{{ typedef
> __haiku_build_haiku_std_int8 __haiku_std_int8; }}} or all of the
> ones inside the #ifndef _HAIKU_BUILD_LIBROOT_FUNCTION_WRAPPER section
> or something else entirely? :)

I mean the whole section. I used __haiku_std_int8 just as an example -- the 
argument is the same for the other __haiku_* types and the macros.

CU, Ingo

Other related posts: