[haiku-commits] Re: AW: r37166 - haiku/trunk/src/apps/showimage

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 18 Jun 2010 23:02:23 +0200

On 2010-06-18 at 20:07:54 [+0200], Michael Pfeiffer 
<michael.w.pfeiffer@xxxxxxxxx> wrote:
> &gt; Removed one liner function that was only called from one place.&nbsp;
> 
> IMO this change slightly reduced readability of source code.

Actually I don't agree and I hinted at the reason in the commit message. 
Everything is in ShowImageView, the class is totally bloated and it's hard 
to make changes to it. So I am trying to do anything to reduce the code in 
that file. I am going to refactor more, but unfortunately my progress is 
slow at the moment.

While we are discussing this, I am planning to completely remove the 
selection editing, i.e. dragging chunks of bitmaps around. I find it 
utterly useless. It may have been coded at Be for demo purposes, lacking 
image editing capabilities otherwise, but I find the functionality a) 
misplaced in ShowImage, and b) much to limited to be useful anyway. And 
WonderBrush comes standard in Haiku releases... :-)

Here are some other changes I would like to make:

* Dragging an image onto a ShowImage window should open that image, instead 
of placing it on top of the current image as a selection.

* The window size and position should be remembered, instead of chosing 
some "optimal" size at each launch time.

* Node monitoring on the current image.

* When moving the current image out of the folder via Tracker, make 
ShowImage still navigate the original folder. (Requires node monitoring to 
begin with.)

When I was sorting some baby fotos the other day, these were the most 
annoying problems. ;-)

Best regards,
-Stephan


Other related posts: