[haiku-bugs] Re: [Haiku] #8252: [PATCH] Create a "debug" build profile for use with Buildbot
- From: "umccullough" <trac@xxxxxxxxxxxx>
- Date: Fri, 23 Dec 2011 16:28:52 -0000
#8252: [PATCH] Create a "debug" build profile for use with Buildbot
----------------------------+----------------------------
Reporter: umccullough | Owner: bonefish
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Build System | Version: R1/Development
Resolution: | Keywords: buildbot debug
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------+----------------------------
Comment (by umccullough):
Replying to [comment:16 bonefish]:
> Just add a `DEBUG = 0 ;` line in the respective Jamfiles somewhere
between the `SubDir` and the rule invocation for the first target. Ideally
with a comment.
OK, Will do.
> With 3rd party I mean code that is still developed outside of our
repository and might be updated or outsourced eventually. Hence I would
consider `libprint` "absorbed", but yes to the others. Moreover coreutils
and ctags fall into my 3rd party category. tcpdump as well, though it
seems to have been customized quite a bit, so the debug code should
probably better be fixed.
Ah, that makes sense.
> `Avoid-warning-in-debug-code-for-media-server.patch`: What's the warning
and why does the patch fix it? Looks completely equivalent to me.
>
> `Fix-warnings-in-OpenSound-debug-code.patch`: First part OK, the second
part, just like the previous patch, I don't understand.
Right, these two were a bit subtle.
The warning was about an unused variable. Apparently these variables are
only initialized in an "#ifdef DEBUG" block, but further down, they are
only used in a TRACE() line... which I suppose may not always be enabled
with DEBUG.
By moving the initialization below the definition, the "unused variable"
warning seemed to go away. Is there a better suggestion?
Quick reference links:
http://cgit.haiku-os.org/haiku/tree/src/servers/media/NodeManager.cpp#n255
http://cgit.haiku-os.org/haiku/tree/src/add-ons/media/media-add-
ons/opensound/OpenSoundNode.cpp#n562
--
Ticket URL: <http://dev.haiku-os.org/ticket/8252#comment:17>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
