[haiku-bugs] Re: [Haiku] #8252: [PATCH] Create a "debug" build profile for use with Buildbot
- From: "bonefish" <trac@xxxxxxxxxxxx>
- Date: Fri, 23 Dec 2011 08:49:03 -0000
#8252: [PATCH] Create a "debug" build profile for use with Buildbot
----------------------------+----------------------------
Reporter: umccullough | Owner: bonefish
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Build System | Version: R1/Development
Resolution: | Keywords: buildbot debug
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------+----------------------------
Comment (by bonefish):
Replying to [comment:15 umccullough]:
> Replying to [comment:12 bonefish]:
> > I forgot to mention: For the third-party code with errors I would
simply disable debugging (i.e. override DEBUG) in the respective Jamfiles.
>
> I wasn't sure how to do this - so the last patch I attached here has all
of the logic in BuildSetup still.
Just add a `DEBUG = 0 ;` line in the respective Jamfiles somewhere between
the `SubDir` and the rule invocation for the first target. Ideally with a
comment.
> The 3rd party dirs we likely won't mess with are the two printing libs
and the ffmpeg stuff I guess?
With 3rd party I mean code that is still developed outside of our
repository and might be updated or outsourced eventually. Hence I would
consider `libprint` "absorbed", but yes to the others. Moreover coreutils
and ctags fall into my 3rd party category. tcpdump as well, though it
seems to have been customized quite a bit, so the debug code should
probably better be fixed.
Regarding the patches:
{{{
Fix-implicit-void-cast-in-usb_midi-debug-code.patch
Fix-warning-in-AutoMounter-debug-code.patch
Fix-warning-in-BSnow-debug-code.patch
Fix-bad-debug-print-in-canna.patch
Fix-various-issues-in-cortex-debug-code.patch
Fix-PDF-print-driver-debug-code.patch
Fix-another-mouse-preference-issue-specific-to-gcc4-.patch
Signed-off-by: Ingo Weinhold <ingo_weinhold@xxxxxx>
}}}
`Avoid-warning-in-debug-code-for-media-server.patch`: What's the warning
and why does the patch fix it? Looks completely equivalent to me.
`Fix-warnings-in-OpenSound-debug-code.patch`: First part OK, the second
part, just like the previous patch, I don't understand.
PS: It would really be nice to have that "Apply Patch" button in Trac.
--
Ticket URL: <http://dev.haiku-os.org/ticket/8252#comment:16>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
